DM-14467: Make SqlRegistry more transactional #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
May 31, 2018
| try: | ||
| yield | ||
| trans.commit() | ||
| except Exception: |
There was a problem hiding this comment.
Are we sure that this should not be BaseException? If I do a Ctrl-C what happens?
| trans = self._connection.begin() | ||
| try: | ||
| yield | ||
| trans.commit() |
There was a problem hiding this comment.
Should the commit be in a finally block?
There was a problem hiding this comment.
No, because we don't want to commit in case an exception is raised.
There was a problem hiding this comment.
I'm sorry. I meant an else block. So that we don't try to run the rollback if the commit itself failed.
- Add transaction context manager. - Disable DatasetType cache. - Add _transactional decorator around members that modify state. Also register DatasetTypes in tests.
pschella
force-pushed
the
tickets/DM-14467
branch
from
5ea0f5c
to
018a822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.