DM-28717: Allow for Stamps formatter to handle bbox #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Mar 2, 2021
| @@ -184,8 +184,14 @@ storageClasses: | |||
| pytype: lsst.verify.Measurement | |||
| Stamps: | |||
| pytype: lsst.meas.algorithms.Stamps | |||
| parameters: | |||
| - bbox | |||
| - origin | |||
There was a problem hiding this comment.
The reader seems to only do something with the bbox parameter. What am I missing?
There was a problem hiding this comment.
Hah! Thanks for asking. I'd just stupidly copied from Image. Removed and tested!
| BrightStarStamps: | ||
| pytype: lsst.meas.algorithms.brightStarStamps.BrightStarStamps | ||
| parameters: | ||
| - bbox | ||
| - origin |
MorganSchmitz
force-pushed
the
tickets/DM-28717
branch
2 times, most recently
from
d525e61
to
a82e499
Compare
MorganSchmitz
changed the title
MorganSchmitz
force-pushed
the
tickets/DM-28717
branch
from
a82e499
to
39d8da4
Compare
MorganSchmitz
force-pushed
the
tickets/DM-28717
branch
from
39d8da4
to
b629efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of four PRs for DM-28717, the others being afw, obs_base and meas_algorithms.