DM-29011: Add support for ButlerURI.walk() #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Mar 4, 2021
ktlim
reviewed
Mar 4, 2021
It's arguable that this was never the intent and should always complain.
normpath strips the trailing / and we need to add it back otherwise geturl does not include it.
os.walk can return [] so mypy has to be told this is possible.
Returning a lot of individual 1-file groups is not going to be useful for raw ingest. Makes more sense to combine them all into a single group.
Explains that we are not downloading all the keys in one go and collating locally because that can become an unbounded problem for large buckets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for S3 and File URIs.