DM-29073: Make ButlerURI immutable #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the way that the `replace()` method calls the constructor and it makes sense to bypass the automatic logic since `replace()` should be returning whatever class it was given.
This affects the updateExtension and updateFile methods which are now renamed to updatedExtension and updatedFile
updateFile -> updatedFile updateExtension -> updatedExtension
This unifies the logic to a single place for non-file code (file code can actually check that it really is a directory)
This is possible now that a ButlerURI is immutable.
ktlim
reviewed
Mar 5, 2021
|
@TallJimbo this PR looks bigger than it really is because of all the docstring fixes. I'm hoping you can skip over those relatively quickly. |
Previously it was implicit through the __copy__ method.
TallJimbo
approved these changes
Mar 5, 2021
| ------- | ||
| updated : `ButlerURI` | ||
| URI with the specified extension. Can return itself if | ||
| no extension was specified. |
There was a problem hiding this comment.
Would it be worthwhile to optimize the case where the extension is already the given one, too?
This is mostly changing multi-line summaries to single lines. That is sometimes a bit annoying.
Restricted to the core/ directory for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.