DM-25965: Add ButlerURI.abspath() method #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Mar 17, 2021
|
After starting to look at |
|
I fixed the FileDataset declaration to allow ButlerURI. I don't think we do stringify them as part of ingest so I don't think it's a problem. There are a couple of places where we call ButlerURI but that's lightweight now since it's immutable. |
timj
force-pushed
the
tickets/DM-25965
branch
3 times, most recently
from
341b62e
to
1bd46d5
Compare
This is now very lightweight since URIs are immutable. Forces scheme-less URIs to file URIs.
This should never happen but is the last line of defence against a confusing error message later on when the insert into the table recording the dataset fails.
This can happen if by some chance someone asks the same file to be ingested from two different locations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now very lightweight since URIs are immutable.
Forces scheme-less URIs to file URIs.