Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-29383: Implement basic caching for remote datasets in Datastore #496

Merged
merged 2 commits into from Mar 26, 2021
Merged

DM-29383: Implement basic caching for remote datasets in Datastore #496

merged 2 commits into from Mar 26, 2021

Conversation

timj
Copy link
Member

@timj timj commented Mar 26, 2021

Currently there is no cache expiry.

@timj timj requested a review from TallJimbo March 26, 2021 00:07
TallJimbo
TallJimbo approved these changes Mar 26, 2021
View reviewed changes
python/lsst/daf/butler/configs/datastores/fileDatastore.yaml Outdated Show resolved Hide resolved
python/lsst/daf/butler/core/datastoreCacheManager.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/core/datastoreCacheManager.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/datastores/fileDatastore.py Outdated Show resolved Hide resolved
@timj
Implement basic caching for remote datasets in Datastore
fe4648a 
Currently there is no cache expiry.
@timj
Change move_to_cache to also check should_be_cached
dcb0822 
This simplifies the usage in file datastore.
@timj timj merged commit a73f724 into master Mar 26, 2021
@timj timj deleted the tickets/DM-29383 branch March 26, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo