DM-28315: Create Registry ABC #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-28315
branch
2 times, most recently
from
3f039d4
to
d457959
Compare
The code imported items that were not explicitly exported and subject to failures when code is reorganized.
* Rename old Registry -> SqlRegistry * Registry.fromConfig now loads class name from config
These need some thought but add them for now to placate mypy. Datastore client/server is going to be complicated.
|
I've redone the commit history to try to give git a chance to handle the changes in #500 when either that is rebased onto this or this is rebased onto that. |
andy-slac
approved these changes
Apr 7, 2021
|
@andy-slac Thanks. Some of your comments are from existing code that I moved around but I will take a look at them. I was minimizing changes to the old |
This had long since been moved to a different location.
This is used by pipetask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.