DM-29562: Rewrite dataset subquery logic to make it easier on query planners. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-29562
branch
3 times, most recently
from
15928a3
to
78294ae
Compare
andy-slac
approved these changes
Apr 11, 2021
Comment on lines
+469
to
+435
| # Also constrain dataset_type_id in static table in case that helps | ||
| # generate a better plan. | ||
| # We could also include this in the JOIN ON clause, but my guess is | ||
| # that that's a good idea IFF it's in the foreign key, and right | ||
| # now it isn't. | ||
| query.where.append(self._static.dataset.columns.dataset_type_id == self._dataset_type_id) |
There was a problem hiding this comment.
I don't think that this is helping as the constraint on dataset_id is already very strict, but I hope it is not hurting either.
TallJimbo
force-pushed
the
tickets/DM-29562
branch
from
78294ae
to
abcb06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.