Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27412: Rework daf.butler.tests.makeTestCollection #507

Merged
merged 1 commit into from Apr 13, 2021
Merged

DM-27412: Rework daf.butler.tests.makeTestCollection #507

merged 1 commit into from Apr 13, 2021

Conversation

kfindeisen
Copy link
Member

This PR alters makeTestCollection to support an externally provided test ID.

parejkoj
parejkoj approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, but otherwise this is a good improvement.

python/lsst/daf/butler/tests/_testRepo.py Outdated Show resolved Hide resolved
tests/test_testRepo.py Outdated Show resolved Hide resolved
@kfindeisen kfindeisen merged commit 943455e into master Apr 13, 2021
@kfindeisen kfindeisen deleted the tickets/DM-27412 branch April 13, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kfindeisen @parejkoj