DM-14760: Merge StorageFileInfo into StorageInfo #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
force-pushed
the
tickets/DM-14639
branch
from
e285ef7
to
5605bff
Compare
Since StorageInfo is now solely the datastore name, there is no reason for registry.updateStorageInfo to exist so it has been removed.
TallJimbo
approved these changes
Aug 23, 2018
| @@ -58,6 +58,10 @@ def __init__(self, formatter, path, storageClass): | |||
| self._path = path | |||
| assert isinstance(storageClass, StorageClass) | |||
| self._storageClass = storageClass | |||
| assert checksum is None or isinstance(checksum, str) | |||
There was a problem hiding this comment.
Currently computeChecksum returns a hex digest as a str. We don't have byte checksums flying around.
|
|
||
| def __repr__(self): | ||
| return f"{type(self).__qualname__}(path=\"{self.path}\", formatter=\"{self.formatter}\"" \ | ||
| f" size={self.size}, checksum=\"{self.checksum}\", storageClass=\"{self.storageClass.name}\")" |
There was a problem hiding this comment.
This is pretty hard to read with all the escaping - seems like a solid reason to use single-quotes in some of these places.
StorageInfo now only has a single item in it so change all the APIs to be explicit about that item. Rename the StorageInfo registry methods as Address methods. getAddresses now returns all matching datastores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.