Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14771: Add support for views to Schema #52

Merged
merged 4 commits into from
Jun 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
108 changes: 51 additions & 57 deletions config/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ schema:
type: string
doc: A string value composed only of letters, numbers, and underscores.

dataunit_joins:
dataUnitJoins:
ExposureRangeJoin:
doc: >
A calculated join between Datasets identified with an Exposure
Expand Down Expand Up @@ -844,10 +844,9 @@ schema:
tgt:
- Visit.camera
- Visit.visit
sql: >
CREATE VIEW VisitSkyPixJoin
SELECT DISTINCT camera, visit, skypix
FROM VisitSensorSkyPixJoin;
sql: >
SELECT DISTINCT camera, visit, skypix
FROM VisitSensorSkyPixJoin;

PatchSkyPixJoin:
doc: >
Expand Down Expand Up @@ -931,10 +930,9 @@ schema:
tgt:
- Tract.skymap
- Tract.tract
sql: >
CREATE VIEW TractPixJoin
SELECT DISTINCT skymap, tract, skypix
FROM PatchSkyPixJoin;
sql: >
SELECT DISTINCT skymap, tract, skypix
FROM PatchSkyPixJoin;

VisitSensorPatchJoin:
doc: >
Expand Down Expand Up @@ -1004,19 +1002,18 @@ schema:
- Patch.skymap
- Patch.tract
- Patch.patch
sql: >
CREATE VIEW VisitSensorPatchJoin AS
SELECT DISTINCT
VisitSensorSkyPixJoin.camera,
VisitSensorSkyPixJoin.visit,
VisitSensorSkyPixJoin.sensor,
PatchSkyPixJoin.skymap,
PatchSkyPixJoin.tract,
PatchSkyPixJoin.patch
FROM
VisitSensorSkyPixJoin INNER JOIN PatchSkyPixJoin ON (
VisitSensorSkyPixJoin.skypix = PatchSkyPixJoin.skypix
);
sql: >
SELECT DISTINCT
VisitSensorSkyPixJoin.camera,
VisitSensorSkyPixJoin.visit,
VisitSensorSkyPixJoin.sensor,
PatchSkyPixJoin.skymap,
PatchSkyPixJoin.tract,
PatchSkyPixJoin.patch
FROM
VisitSensorSkyPixJoin INNER JOIN PatchSkyPixJoin ON (
VisitSensorSkyPixJoin.skypix = PatchSkyPixJoin.skypix
);

VisitPatchJoin:
doc: >
Expand Down Expand Up @@ -1080,18 +1077,17 @@ schema:
- Patch.skymap
- Patch.tract
- Patch.patch
sql: >
CREATE VIEW VisitPatchJoin AS
SELECT DISTINCT
VisitSkyPixJoin.camera,
VisitSkyPixJoin.visit,
PatchSkyPixJoin.skymap,
PatchSkyPixJoin.tract,
PatchSkyPixJoin.patch
FROM
VisitSkyPixJoin INNER JOIN PatchSkyPixJoin ON (
VisitSkyPixJoin.skypix = PatchSkyPixJoin.skypix
);
sql: >
SELECT DISTINCT
VisitSkyPixJoin.camera,
VisitSkyPixJoin.visit,
PatchSkyPixJoin.skymap,
PatchSkyPixJoin.tract,
PatchSkyPixJoin.patch
FROM
VisitSkyPixJoin INNER JOIN PatchSkyPixJoin ON (
VisitSkyPixJoin.skypix = PatchSkyPixJoin.skypix
);

VisitSensorTractJoin:
doc: >
Expand Down Expand Up @@ -1156,18 +1152,17 @@ schema:
tgt:
- Tract.skymap
- Tract.tract
sql: >
CREATE VIEW VisitSensorTractJoin AS
SELECT DISTINCT
VisitSensorSkyPixJoin.camera,
VisitSensorSkyPixJoin.visit,
VisitSensorSkyPixJoin.sensor,
TractSkyPixJoin.skymap,
TractSkyPixJoin.tract
FROM
VisitSensorSkyPixJoin INNER JOIN TractSkyPixJoin ON (
VisitSensorSkyPixJoin.skypix = TractSkyPixJoin.skypix
);
sql: >
SELECT DISTINCT
VisitSensorSkyPixJoin.camera,
VisitSensorSkyPixJoin.visit,
VisitSensorSkyPixJoin.sensor,
TractSkyPixJoin.skymap,
TractSkyPixJoin.tract
FROM
VisitSensorSkyPixJoin INNER JOIN TractSkyPixJoin ON (
VisitSensorSkyPixJoin.skypix = TractSkyPixJoin.skypix
);

VisitTractJoin:
doc: >
Expand Down Expand Up @@ -1226,17 +1221,16 @@ schema:
tgt:
- Tract.skymap
- Tract.tract
sql: >
CREATE VIEW VisitTractJoin AS
SELECT DISTINCT
VisitSkyPixJoin.camera,
VisitSkyPixJoin.visit,
TractSkyPixJoin.skymap,
TractSkyPixJoin.tract
FROM
VisitSkyPixJoin INNER JOIN TractSkyPixJoin ON (
VisitSkyPixJoin.skypix = TractSkyPixJoin.skypix
);
sql: >
SELECT DISTINCT
VisitSkyPixJoin.camera,
VisitSkyPixJoin.visit,
TractSkyPixJoin.skymap,
TractSkyPixJoin.tract
FROM
VisitSkyPixJoin INNER JOIN TractSkyPixJoin ON (
VisitSkyPixJoin.skypix = TractSkyPixJoin.skypix
);

tables:
Dataset:
Expand Down
6 changes: 5 additions & 1 deletion python/lsst/daf/butler/butler.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class Butler:
"""

@staticmethod
def makeRepo(root, config=None, standalone=False):
def makeRepo(root, config=None, standalone=False, createRegistry=True):
"""Create an empty data repository by adding a butler.yaml config
to a repository root directory.

Expand All @@ -95,6 +95,8 @@ def makeRepo(root, config=None, standalone=False):
may be good or bad, depending on the nature of the changes).
Future *additions* to the defaults will still be picked up when
initializing `Butlers` to repos created with ``standalone=True``.
createRegistry : `bool`
If `True` create a new Registry.

Note that when ``standalone=False`` (the default), the configuration
search path (see `ConfigSubset.defaultSearchPaths`) that was used to
Expand Down Expand Up @@ -130,6 +132,8 @@ def makeRepo(root, config=None, standalone=False):
if standalone:
config.merge(full)
config.dumpToFile(os.path.join(root, "butler.yaml"))
# Create Registry and populate tables
registryClass.fromConfig(config, create=createRegistry)
return config

def __init__(self, config=None, collection=None, run=None):
Expand Down
85 changes: 83 additions & 2 deletions python/lsst/daf/butler/core/dataUnit.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,60 @@ def validateId(self, dataId):
missing, dataId, self.name))


class DataUnitJoin:
"""Represents a join between one or more `DataUnit`s.

Parameters
----------
name : `str`
Name of this `DataUnit` (`str`, read-only).
Also assumed to be the name of the primary table (if present).
lhs : `tuple`
Left-hand-side of the join.
rhs : `tuple`
Right-hand-side of the join.
summarizes : `DataUnitJoin`
Summarizes this other `DataUnitJoin`.
table : `sqlalchemy.TableClause` or `sqlalchemy.Table`
The table to be used for queries. Note that this is not
an actual `Table` in many cases because joins are often
materialized as views (and thus are also not present
in `Registry._schema._metadata`).
"""
def __init__(self, name, lhs=None, rhs=None, summarizes=None, table=None):
self._name = name
self._lhs = lhs
self._rhs = rhs
self._summarizes = summarizes
self._table = table

@property
def name(self):
"""Name of this `DataUnit` (`str`, read-only).

Also assumed to be the name of the primary table (if present)."""
return self._name

@property
def lhs(self):
return self._lhs

@property
def rhs(self):
return self._rhs

@property
def summarizes(self):
return self._summarizes

@property
def table(self):
"""When not ``None`` the primary table entry corresponding to this
`DataUnitJoin` (`sqlalchemy.core.TableClause`, optional).
"""
return getattr(self, '_table', None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just self._table?



class DataUnitRegistry:
"""Instances of this class keep track of `DataUnit` relations.

Expand All @@ -161,6 +215,7 @@ def __init__(self):
self._dataUnits = {}
self.links = {}
self.constraints = []
self.joins = {}

@classmethod
def fromConfig(cls, config, builder=None):
Expand All @@ -177,8 +232,9 @@ def fromConfig(cls, config, builder=None):
When given, create `sqlalchemy.core.Table` entries for every `DataUnit` table.
"""
dataUnitRegistry = cls()
dataUnitRegistry._initDataUnitNames(config)
dataUnitRegistry._initDataUnits(config, builder)
dataUnitRegistry._initDataUnitNames(config['dataUnits'])
dataUnitRegistry._initDataUnits(config['dataUnits'], builder)
dataUnitRegistry._initDataUnitJoins(config['dataUnitJoins'], builder)
return dataUnitRegistry

def __len__(self):
Expand Down Expand Up @@ -275,6 +331,31 @@ def _initDataUnits(self, config, builder):
link=link)
self[dataUnitName] = dataUnit

def _initDataUnitJoins(self, config, builder):
"""Initialize `DataUnit` join entries.

Parameters
----------
config : `SchemaConfig`
Schema configuration describing `DataUnit` join relations.
builder : `SchemaBuilder`, optional
When given, create `sqlalchemy.core.Table` entries for every `DataUnit` table.
"""
for dataUnitJoinName, dataUnitJoinDescription in config.items():
table = None
if 'tables' in dataUnitJoinDescription and builder is not None:
for tableName, tableDescription in dataUnitJoinDescription['tables'].items():
table = builder.addTable(tableName, tableDescription)
lhs = frozenset((dataUnitJoinDescription.get('lhs', None)))
rhs = frozenset((dataUnitJoinDescription.get('rhs', None)))
summarizes = dataUnitJoinDescription.get('summarizes', None)
dataUnitJoin = DataUnitJoin(name=dataUnitJoinName,
lhs=lhs,
rhs=rhs,
summarizes=summarizes,
table=table)
self.joins[(lhs, rhs)] = dataUnitJoin

def getPrimaryKeyNames(self, dataUnitNames):
"""Get all primary-key column names for the given ``dataUnitNames``.

Expand Down
8 changes: 5 additions & 3 deletions python/lsst/daf/butler/core/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def setConfigRoot(cls, root, config, full):
raise NotImplementedError()

@staticmethod
def fromConfig(registryConfig, schemaConfig=None):
def fromConfig(registryConfig, schemaConfig=None, create=False):
"""Create `Registry` subclass instance from `config`.

Uses ``registry.cls`` from `config` to determine which subclass to instantiate.
Expand All @@ -85,6 +85,8 @@ def fromConfig(registryConfig, schemaConfig=None):
Schema configuration. Can be read from supplied registryConfig
if the relevant component is defined and ``schemaConfig`` is
`None`.
create : `bool`
Assume empty Registry and create a new one.

Returns
-------
Expand All @@ -108,9 +110,9 @@ def fromConfig(registryConfig, schemaConfig=None):
raise ValueError("Incompatible Registry configuration: {}".format(registryConfig))

cls = doImport(registryConfig['cls'])
return cls(registryConfig, schemaConfig)
return cls(registryConfig, schemaConfig, create=create)

def __init__(self, registryConfig, schemaConfig=None):
def __init__(self, registryConfig, schemaConfig=None, create=False):
assert isinstance(registryConfig, RegistryConfig)
self.config = registryConfig

Expand Down