DM-30140: Allow trash to take iterable of dataset refs #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
May 12, 2021
This is much much faster than calling trash on each ref separately. Also remove the existence check since if we are asking for a dataset to be trashed it is not really that important if the dataset has already disappeared and that could just be caused by someone else prunning a collection in parallel.
The indirection was not helping anything since it only included one call that was generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much much faster than calling trash on each ref separately. Also remove the existence check since if we are asking for a dataset to be trashed it is not really that important if the dataset has already disappeared and that could just be caused by someone else pruning a collection in parallel.