DM-30685: Issue warning if lookup key dimension is not known to universe #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a confusing KeyError would be issued with the unknown key. Now replace this with a warning message suggesting that there might be a typo but still continue on without stopping. This is mainly motivated by the presence of physical_filter in the fileDatastore file template. Since this is in a default configuration it affects all users, even those that define their own universe. DM-26190 may give us the real fix for the fileDatastore problem.
tgoldina
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a confusing KeyError would be issued with the unknown key.
Now replace this with a warning message suggesting that there might be a typo
but still continue on without stopping.
This is mainly motivated by the presence of physical_filter in the
fileDatastore file template. Since this is in a default configuration
it affects all users, even those that define their own universe.
DM-26190 may give us the real fix for the fileDatastore problem.
Checklist
doc/changes