DM-30771: Allow components to be missing in datastore trust mode #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleGower
approved these changes
Jun 16, 2021
| @@ -584,6 +584,20 @@ def _prepare_for_get(self, ref: DatasetRef, | |||
|
|
|||
| if len(fileLocations) > 1: | |||
| disassembled = True | |||
|
|
|||
| # If trust is involved it is possible that there will be too | |||
| # many components listed here. We need to explicitly check | |||
There was a problem hiding this comment.
I don't understand this first sentence. Is it because some components appear in the execution butler because it has everything for the run but some components will not be written until a later Quantum execution? The rest of the comment and the code makes sense.
There was a problem hiding this comment.
Registry has no concept of components so nothing in registry can tell me whether all components were written or only some of them. On read if you ask for a calexp.wcs it will know to look for exactly the wcs component so will fail or not depending on the presence of the file.
When disassembling a composite we can't assume that all components will exist. In trust mode assume that any components found means that these should be passed on to the assembler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disassembling a composite we can't assume that all components
will exist. In trust mode assume that any components found means
that these should be passed on to the assembler.
Checklist
doc/changes