DM-30784: Fixes to transfer_from to correctly filter out missing datasets and register dataset types #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file might be missing now for some unknown reason or the user may have deleted the dataset but retained the registry record. It's best to report it as predicted rather than refuse to show anything. To support dynamic prediction we need a fully expanded dataId.
This requires we move to an explicit transaction around the dataset import loop and datastore artifact transfer.
andy-slac
approved these changes
Jun 17, 2021
Execution butler workflow may have only partially completed.
Composites may not have written all components.
We can only test for the existence of any of the files and not all the expected files since we don't know whether a composite will always write out all components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that I had forgotten a rather critical filter and was transferring all datasets, even those that had not file artifact. This is now fixed. This PR also adds dataset type registration.
Checklist
doc/changes