Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-30767: support component exports (by exporting comparent composites) #539

Merged
merged 2 commits into from Jun 23, 2021

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Jun 18, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement. Is this needed because components requested in a pipeline were being skipped before in pipe_base when creating the execution butler but now are included? I'm now worrying whether I need to fix the disassembled composites export problem -- easy to check by defining a pipeline that can use the outputs of the pipelines_check repo and create an execution butler from the output collection.

@TallJimbo
Copy link
Member Author

Is this needed because components requested in a pipeline were being skipped before in pipe_base when creating the execution butler but now are included?

I believe that's the case. But component-dataset inputs are rare in our concrete pipelines, and it's even more rare to start processing with one, so it probably would have been along time before we'd have noticed.

Previous behavior was to export the component, which could not
actually be imported.
This addresses what seemed to be a TODO comment whose conditions had
been met a while ago.
@timj
Copy link
Member

timj commented Jun 19, 2021

It's not about specifying components as input, it's about composite disassembly in general since we are creating the execution butler by exporting then importing datasets rather than using butler.datastore.transfer_from(). The former can't handle disassembled composites regardless whereas the latter can because it deals with the datastore records directly rather than going through that exporter class that doesn't know about disassembly. I think the demonstration is fairly simple: run pipelines_check and then run a new pipeline using those outputs -- the execution butler will refuse to be built I think.

@TallJimbo
Copy link
Member Author

I think the demonstration is fairly simple: run pipelines_check and then run a new pipeline using those outputs -- the execution butler will refuse to be built I think.

Understood. But since it sounds like execution butler + disassembly is already broken, I'm not going to try to fix it on this ticket, and I'll let you create a new one if you want to tackle it. I really hope we can replace execution butler with something else before we ever consider disassembly in production, but of course we'll still want import/export to be able to handle disassembly anyway.

@TallJimbo TallJimbo merged commit fd66196 into master Jun 23, 2021
@TallJimbo TallJimbo deleted the tickets/DM-30767 branch June 23, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants