DM-30855: Fix support for click 8.x #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice to be able to verify a sensible error message is returned for the failure condition but the click UI is too dynamic; so instead we test for a failure (non-zero exit code) but otherwise punt on verifying exactly _what_ failed.
timj
commented
Jun 23, 2021
| @@ -490,7 +490,7 @@ def convert(self, value, param, ctx): | |||
| """Called by click.ParamType to "convert values through types". | |||
| `click.Path` uses this step to verify Path conditions.""" | |||
| if self.mustNotExist and os.path.exists(value): | |||
| self.fail(f'{self.path_type} "{value}" should not exist.') | |||
| self.fail(f'Path "{value}" should not exist.') | |||
There was a problem hiding this comment.
Turns out that in click 8 they changed .path_type to .type (presumably for consistency).
They have replaced with Path.type but supporting this would mean special logic for click7 and the type is always going to be str in our usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes