Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31249: Add some test for ButlerURI.join() #550

Merged
merged 1 commit into from Jul 31, 2021
Merged

DM-31249: Add some test for ButlerURI.join() #550

merged 1 commit into from Jul 31, 2021

Conversation

timj
Copy link
Member

@timj timj commented Jul 29, 2021 •
edited

Now raises if an absolute scheme-less URI is given. The test
uncovered a small problem with quoting of the join path and that
is also fixed.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj
Add some test for ButlerURI.join()
3fcf39e 
Now raises if an absolute scheme-less URI is given. The test
uncovered a small problem with quoting of the join path and that
is also fixed.
@timj timj requested a review from SergeyPod July 29, 2021 21:46
SergeyPod
SergeyPod approved these changes Jul 30, 2021
View reviewed changes
Copy link

@SergeyPod SergeyPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that patch provided by this pull request code raises exception as expected. Looks good to me.

@timj timj merged commit cf79cce into master Jul 31, 2021
@timj timj deleted the tickets/DM-31249 branch July 31, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyPod SergeyPod SergeyPod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @SergeyPod