Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31295: Cache boto client and add timer messages to logs for some file I/O #552

Merged
merged 5 commits into from Aug 4, 2021
Merged

DM-31295: Cache boto client and add timer messages to logs for some file I/O #552

merged 5 commits into from Aug 4, 2021

Conversation

timj
Copy link
Member

@timj timj commented Aug 4, 2021 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

ktlim
ktlim approved these changes Aug 4, 2021
View reviewed changes
python/lsst/daf/butler/core/_butlerUri/file.py Show resolved Hide resolved
python/lsst/daf/butler/core/_butlerUri/http.py Show resolved Hide resolved
python/lsst/daf/butler/core/utils.py Outdated Show resolved Hide resolved
@ktlim
Copy link
Contributor

ktlim commented Aug 4, 2021

Maybe change the PR title to reflect the addition of session caching?

@timj timj changed the title DM-31295: Add timer messages to logs for some file I/O DM-31295: Cache boto client and add timer messages to logs for some file I/O Aug 4, 2021
@timj
Default time_this to use prefix="timer" and drop log_ name in params
5c0903f 
We want to always use "timer" as the prefix so set it as the
default. Also change log_prefix -> prefix and log_level -> level
@timj timj merged commit fa59942 into master Aug 4, 2021
@timj timj deleted the tickets/DM-31295 branch August 4, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktlim ktlim ktlim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @ktlim