DM-31520: Allow butler collection-chain to have comma-separated children #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleGower
approved these changes
Aug 27, 2021
| @@ -529,7 +529,11 @@ def collection_chain(**kwargs): | |||
| CHILDREN are the collections to be used to modify the chain. The exact | |||
| usage depends on the MODE option. When the MODE is 'pop' the CHILDREN | |||
| should be integer indices indicating collections to be removed from | |||
| the current chain. | |||
| the current chain. The supplied values will be split on comma. For example, | |||
There was a problem hiding this comment.
Recommend moving the new text prior to the statement about modes (or put in new "paragraph") so it's not confused as a continuation of the pop information.
This simplifies the movement of options for pipetask which do include commas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the movement of options for pipetask which do
include commas.
Checklist
doc/changes