DM-29531: Update IsrCalib so it can serve as StorageClass for subclasses #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
This looks fine. At some point we need to clear out the entries for the older calib classes but there's no rush for that.
You could add inheritsFrom: to the yaml for CrossTalkCalib for example and that would mean that the actual StorageClass for CrossTalkCalib will explicitly be related to IsrCalib but it's not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add formatter and storageClass information for IsrCalib.
Checklist
doc/changes