Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-31769 Remove Placeholder from DatasetType #586

Merged
merged 1 commit into from Oct 28, 2021
Merged

Conversation

natelust
Copy link
Contributor

Previously a placeholder was created to aid in graph creation
involving component dataset types. Graph creation code was modified
such that this no longer needs to be an attribute of DatasetType.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #586 (c5f4ef8) into master (f03b063) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   83.55%   83.53%   -0.02%     
==========================================
  Files         241      241              
  Lines       30253    30228      -25     
  Branches     4512     4509       -3     
==========================================
- Hits        25277    25252      -25     
  Misses       3784     3784              
  Partials     1192     1192              
Impacted Files Coverage Δ
python/lsst/daf/butler/core/datasets/type.py 81.25% <ø> (-0.93%) ⬇️
tests/test_datasets.py 99.19% <ø> (-0.05%) ⬇️
tests/test_templates.py 98.75% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03b063...c5f4ef8. Read the comment docs.

Previously a placeholder was created to aid in graph creation
involving component dataset types. Graph creation code was modified
such that this no longer needs to be an attribute of DatasetType.
@natelust natelust merged commit 6f853fa into master Oct 28, 2021
@natelust natelust deleted the tickets/DM-31769 branch October 28, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants