DM-32290: Re-order table creation in dataset manager #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
- Coverage 83.53% 83.52% -0.02%
==========================================
Files 241 241
Lines 30228 30233 +5
Branches 4509 4511 +2
==========================================
+ Hits 25252 25253 +1
- Misses 3784 3786 +2
- Partials 1192 1194 +2
Continue to review full report at Codecov.
|
andy-slac
force-pushed
the
tickets/DM-32290
branch
from
cbd17c4
to
04a4252
Compare
Tags and calib tables are now registered after their creation, this avoids inconsistency if creation fails. Also added checks for table existence when tables need to be read.
andy-slac
force-pushed
the
tickets/DM-32290
branch
from
04a4252
to
687c0d2
Compare
TallJimbo
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags and calib tables are now registered after their creation, this
avoids inconsistency if creation fails. Also added checks for table
existence when tables need to be read.
Checklist
doc/changes