DM-32454: Separate dataset dimensions from requested dimensions in queries. #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-32454
branch
from
aa20d74
to
1f0a257
Compare
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 83.52% 83.51% -0.01%
==========================================
Files 241 241
Lines 30256 30266 +10
Branches 4518 4520 +2
==========================================
+ Hits 25270 25277 +7
- Misses 3790 3793 +3
Partials 1196 1196
Continue to review full report at Codecov.
|
andy-slac
approved these changes
Nov 5, 2021
The dimensions passed directly to queryDataIds were always intended to be the dimensions the caller wanted back, which may not be the same as the dimensions used to constrain the query. We'd partially handled that distinction in the past, but we had been rolling dataset constraint dimensions into the requested set. This was most obvious in queryDimensionRecords, which didn't quite handle this properly, and hence couldn't handle constraints on datasets that have dimensions beyond the dimension records' own. Fixing queryDataIds to track dataset-constraint dimensions separately solves that problem, too.
TallJimbo
force-pushed
the
tickets/DM-32454
branch
from
201571f
to
b2aa584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes