Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32467: Allow a Path object to be used in Butler constructor #596

Merged
merged 3 commits into from Nov 10, 2021

Conversation

timj
Copy link
Member

@timj timj commented Nov 5, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #596 (c0c6a4d) into master (b48bc6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   83.52%   83.53%           
=======================================
  Files         241      241           
  Lines       30275    30292   +17     
  Branches     4521     4522    +1     
=======================================
+ Hits        25286    25303   +17     
  Misses       3793     3793           
  Partials     1196     1196           
Impacted Files Coverage Δ
python/lsst/daf/butler/_butlerConfig.py 94.87% <100.00%> (+0.13%) ⬆️
...thon/lsst/daf/butler/core/_butlerUri/_butlerUri.py 92.11% <100.00%> (+0.02%) ⬆️
tests/test_butler.py 97.51% <100.00%> (+0.02%) ⬆️
tests/test_uri.py 97.48% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48bc6e...c0c6a4d. Read the comment docs.

Copy link
Contributor

@mfisherlevine mfisherlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

tests/test_uri.py Outdated Show resolved Hide resolved
@timj timj merged commit 68e898d into master Nov 10, 2021
@timj timj deleted the tickets/DM-32467 branch November 10, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants