DM-31976: Backport to v23 of transfer datasets cleanup #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-31976-v23
branch
from
e55e83b
to
aab395c
Compare
By default now configure Butler.transfer_from to not register dataset types. As part of this reorganization consistency is now ensured between source butler definitions and target butler definitions.
Make use of the fact that we know whether the new dataset type was registered or not. Also, no longer allow all the dataset types to be processed before complaining. Raise exception on first missing dataset type or first inconsistency.
This indicates whether the collection was created or not.
Runs are still created inside the transaction but we now only call registerRun once per run.
The int->int transfer can randomly end up with clashes if a second import is attempted, so to remove that randomness only run the CHAIN test with datasets that we know are in that collection. This is needed because we do not check all the collections up front.
timj
force-pushed
the
tickets/DM-31976-v23
branch
from
aab395c
to
178eb95
Compare
Codecov Report
@@ Coverage Diff @@
## v23.0.x #598 +/- ##
===========================================
+ Coverage 83.59% 83.61% +0.02%
===========================================
Files 241 241
Lines 30309 30352 +43
Branches 4509 4519 +10
===========================================
+ Hits 25336 25380 +44
+ Misses 3784 3783 -1
Partials 1189 1189
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes