Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-13246: Synchronize DMTN-056 with Butler prototype #6

Merged
merged 1 commit into from Jan 19, 2018
Merged

DM-13246: Synchronize DMTN-056 with Butler prototype #6

merged 1 commit into from Jan 19, 2018

Conversation

pschella
Copy link
Collaborator

No description provided.

TallJimbo
TallJimbo approved these changes Jan 19, 2018
View reviewed changes
python/lsst/butler/schema.py Outdated
Column('visit_begin', Integer, ForeignKey(
'Visit.visit_number'), primary_key=True, nullable=False),
Column('visit_end', Integer, ForeignKey(
'Visit.visit_number'), primary_key=True, nullable=False),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised it makes sense to actually make this a foreign key, given that it's defining a range.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming the range had to be valid. So both need to exist. But perhaps this is not true?

Copy link
Member

@TallJimbo TallJimbo Jan 19, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want at least half-open ranges, presumably marked by null endpoints.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we'll remove the foreign key checks and hope for the best.

Synchronize with DMTN-056
e84dddf 
Additionally:
- Rename tag -> collection
- Rename Path -> StorageHint
@pschella pschella merged commit e84dddf into master Jan 19, 2018
@ktlim ktlim deleted the tickets/DM-13246 branch August 25, 2018 06:49
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Jul 22, 2019
@DinoBektesevic
Review fixes lsst#6
cfa8d72 
Changes
-------

- added `ospath` property to ButlerURI that localizes the posix-like
  uri.path
 - Updated docstrings in ButlerURI class to correctly describe
  what properties/methods do.
- File vs Dir is now resolved by checking if "." is present in path
  for both Config and ButlerConfig. If not Dir, path is no longer
  forced to be the top level directory before updating file name.
- Fixed various badly merged Formatter docstrings and file IO.
- Removed file extension update call in 'to/from'Bytes' methods
  in Formatters.
- Restored `super().setConfigRoot` call in SqliteRegistry.
- Removed extra boto3 present check from test_butler.py
- Fixed badly formatted docstrings in s3utils.
- Renamed `cheap` kwarg to `slow` in `s3CheckFileExists`.
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Jul 29, 2019
@DinoBektesevic
Review fixes lsst#6
845abc0 
Changes
-------

- added `ospath` property to ButlerURI that localizes the posix-like
  uri.path
 - Updated docstrings in ButlerURI class to correctly describe
  what properties/methods do.
- File vs Dir is now resolved by checking if "." is present in path
  for both Config and ButlerConfig. If not Dir, path is no longer
  forced to be the top level directory before updating file name.
- Fixed various badly merged Formatter docstrings and file IO.
- Removed file extension update call in 'to/from'Bytes' methods
  in Formatters.
- Restored `super().setConfigRoot` call in SqliteRegistry.
- Removed extra boto3 present check from test_butler.py
- Fixed badly formatted docstrings in s3utils.
- Renamed `cheap` kwarg to `slow` in `s3CheckFileExists`.
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Jul 29, 2019
@DinoBektesevic
Review fixes lsst#6
59b070b 
Changes
-------

- added `ospath` property to ButlerURI that localizes the posix-like
  uri.path
 - Updated docstrings in ButlerURI class to correctly describe
  what properties/methods do.
- File vs Dir is now resolved by checking if "." is present in path
  for both Config and ButlerConfig. If not Dir, path is no longer
  forced to be the top level directory before updating file name.
- Fixed various badly merged Formatter docstrings and file IO.
- Removed file extension update call in 'to/from'Bytes' methods
  in Formatters.
- Restored `super().setConfigRoot` call in SqliteRegistry.
- Removed extra boto3 present check from test_butler.py
- Fixed badly formatted docstrings in s3utils.
- Renamed `cheap` kwarg to `slow` in `s3CheckFileExists`.
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Aug 6, 2019
@DinoBektesevic
Review fixes lsst#6
35dbbb0 
Changes
-------

- added `ospath` property to ButlerURI that localizes the posix-like
  uri.path
 - Updated docstrings in ButlerURI class to correctly describe
  what properties/methods do.
- File vs Dir is now resolved by checking if "." is present in path
  for both Config and ButlerConfig. If not Dir, path is no longer
  forced to be the top level directory before updating file name.
- Fixed various badly merged Formatter docstrings and file IO.
- Removed file extension update call in 'to/from'Bytes' methods
  in Formatters.
- Restored `super().setConfigRoot` call in SqliteRegistry.
- Removed extra boto3 present check from test_butler.py
- Fixed badly formatted docstrings in s3utils.
- Renamed `cheap` kwarg to `slow` in `s3CheckFileExists`.
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Aug 6, 2019
@DinoBektesevic
Review fixes lsst#6
166d300 
Changes
-------

- added `ospath` property to ButlerURI that localizes the posix-like
  uri.path
 - Updated docstrings in ButlerURI class to correctly describe
  what properties/methods do.
- File vs Dir is now resolved by checking if "." is present in path
  for both Config and ButlerConfig. If not Dir, path is no longer
  forced to be the top level directory before updating file name.
- Fixed various badly merged Formatter docstrings and file IO.
- Removed file extension update call in 'to/from'Bytes' methods
  in Formatters.
- Restored `super().setConfigRoot` call in SqliteRegistry.
- Removed extra boto3 present check from test_butler.py
- Fixed badly formatted docstrings in s3utils.
- Renamed `cheap` kwarg to `slow` in `s3CheckFileExists`.
DinoBektesevic added a commit to DinoBektesevic/daf_butler that referenced this pull request Aug 6, 2019
@DinoBektesevic
Review fixes lsst#6
4f2b95e 
Changes
-------

- added `ospath` property to ButlerURI that localizes the posix-like
  uri.path
 - Updated docstrings in ButlerURI class to correctly describe
  what properties/methods do.
- File vs Dir is now resolved by checking if "." is present in path
  for both Config and ButlerConfig. If not Dir, path is no longer
  forced to be the top level directory before updating file name.
- Fixed various badly merged Formatter docstrings and file IO.
- Removed file extension update call in 'to/from'Bytes' methods
  in Formatters.
- Restored `super().setConfigRoot` call in SqliteRegistry.
- Removed extra boto3 present check from test_butler.py
- Fixed badly formatted docstrings in s3utils.
- Renamed `cheap` kwarg to `slow` in `s3CheckFileExists`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pschella @TallJimbo