Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32491: Add Butler.get_repo_uri class method for searching repository index #603

Merged
merged 4 commits into from Nov 19, 2021

Conversation

timj
Copy link
Member

@timj timj commented Nov 12, 2021

Pretty straightforward implementation of a repository index.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj requested a review from ktlim November 12, 2021 04:59
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #603 (a4b0579) into master (b15e845) will increase coverage by 0.03%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   83.64%   83.67%   +0.03%     
==========================================
  Files         241      242       +1     
  Lines       30624    30700      +76     
  Branches     4591     4595       +4     
==========================================
+ Hits        25614    25688      +74     
- Misses       3812     3814       +2     
  Partials     1198     1198              
Impacted Files Coverage Δ
python/lsst/daf/butler/_butlerRepoIndex.py 95.34% <95.34%> (ø)
python/lsst/daf/butler/__init__.py 100.00% <100.00%> (ø)
python/lsst/daf/butler/_butler.py 78.76% <100.00%> (+0.25%) ⬆️
tests/test_butler.py 97.57% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15e845...a4b0579. Read the comment docs.

python/lsst/daf/butler/_butler.py Outdated Show resolved Hide resolved
tests/test_butler.py Outdated Show resolved Hide resolved
tests/test_butler.py Outdated Show resolved Hide resolved
@timj timj force-pushed the tickets/DM-32491 branch 3 times, most recently from 6142fd3 to 913d7c7 Compare November 18, 2021 20:40
python/lsst/daf/butler/_butlerRepoIndex.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/_butlerRepoIndex.py Show resolved Hide resolved
python/lsst/daf/butler/_butlerRepoIndex.py Show resolved Hide resolved
tests/test_butler.py Show resolved Hide resolved
This is consistent with other butler environment variables
that start with DAF_BUTLER and not BUTLER_.
@timj timj merged commit 5119f2c into master Nov 19, 2021
@timj timj deleted the tickets/DM-32491 branch November 19, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants