Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32144: Suppress warnings for cartesian join #608

Merged
merged 1 commit into from Nov 29, 2021
Merged

Conversation

andy-slac
Copy link
Contributor

Some queries involving user expression can generate cartesian join,
it is harmless as it should normally be constrained to a single row in
a joined table. Instead of trying to avoid cartesian joins we simply
suppress sqlalchemy warnings for one type of query.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #608 (1f7e14e) into main (19c4ce5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1f7e14e differs from pull request most recent head 7363b56. Consider uploading reports for the commit 7363b56 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files         242      242           
  Lines       30703    30706    +3     
  Branches     4595     4595           
=======================================
+ Hits        25691    25694    +3     
  Misses       3814     3814           
  Partials     1198     1198           
Impacted Files Coverage Δ
...ython/lsst/daf/butler/registry/dimensions/table.py 84.41% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c4ce5...7363b56. Read the comment docs.

Some queries involving user expression can generate cartesian join,
it is harmless as it should normally be constrained to a single row in
a joined table. Instead of trying to avoid cartesian joins we simply
suppress sqlalchemy warnings for one type of query.
@andy-slac andy-slac merged commit 5039d9a into main Nov 29, 2021
@andy-slac andy-slac deleted the tickets/DM-32144 branch November 29, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants