Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32750: Complain if unrecognized dataId/kwarg dimension keys are given in Butler APIs #610

Merged
merged 3 commits into from Dec 1, 2021

Conversation

timj
Copy link
Member

@timj timj commented Nov 30, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This will stop irrelevant dimensions being included or
parameters that were used in gen2 but have no meaning in gen3.
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #610 (7dca092) into main (5039d9a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #610    +/-   ##
========================================
  Coverage   83.67%   83.68%            
========================================
  Files         242      242            
  Lines       30706    30715     +9     
  Branches     4595     5121   +526     
========================================
+ Hits        25694    25703     +9     
  Misses       3814     3814            
  Partials     1198     1198            
Impacted Files Coverage Δ
python/lsst/daf/butler/tests/utils.py 92.40% <ø> (ø)
python/lsst/daf/butler/_butler.py 78.93% <100.00%> (+0.17%) ⬆️
tests/test_butler.py 97.57% <100.00%> (ø)
tests/test_simpleButler.py 97.79% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5039d9a...7dca092. Read the comment docs.

@timj timj force-pushed the tickets/DM-32750 branch 2 times, most recently from 1522bb7 to a14a770 Compare December 1, 2021 19:59
@timj timj merged commit 1427568 into main Dec 1, 2021
@timj timj deleted the tickets/DM-32750 branch December 1, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants