Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-32843: v23.0.0 release notes #614

Merged
merged 5 commits into from
Dec 10, 2021
Merged

DM-32843: v23.0.0 release notes #614

merged 5 commits into from
Dec 10, 2021

Conversation

timj
Copy link
Member

@timj timj commented Dec 7, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj requested a review from TallJimbo December 7, 2021 20:37
@timj
Copy link
Member Author

timj commented Dec 7, 2021

@TallJimbo no need to look at every entry. My main request is to consider:

  • Is it worth maintaining separate registry and datastore entries?
  • Should we combine misc and other?

My intent is to backport this to main (which will remove all the v23 news fragments from main).

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #614 (2c9bd5c) into v23.0.x (6a0efd9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2c9bd5c differs from pull request most recent head 1142181. Consider uploading reports for the commit 1142181 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           v23.0.x     #614    +/-   ##
=========================================
  Coverage    83.62%   83.62%            
=========================================
  Files          241      241            
  Lines        30361    30361            
  Branches      4520     5051   +531     
=========================================
  Hits         25389    25389            
  Misses        3783     3783            
  Partials      1189     1189            
Impacted Files Coverage Δ
...n/lsst/daf/butler/registry/databases/postgresql.py 77.36% <ø> (ø)
...n/lsst/daf/butler/registry/interfaces/_database.py 87.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1fb2b6...1142181. Read the comment docs.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for merging other and misc, and I don't think the separation of registry and datastore entries is useful.

Any idea why some entries have ticket links and others do not?

@timj
Copy link
Member Author

timj commented Dec 10, 2021

I think they all have ticket links. Lines that don't are because the link only appears at the end of the entry and some news fragments are multi-line.

ktlim and others added 5 commits December 10, 2021 11:25
We already state that a news fragment is only required for
visible changes so it doesn't really make sense to then
hide the content nd only report the ticket numbers.

We probably should consider merging misc and other into
a single category.
* Merge OTHER and MISC
* Move registry and datastore specific entries into main body.
@timj timj merged commit 7a47537 into v23.0.x Dec 10, 2021
@timj timj deleted the tickets/DM-32843-v23 branch December 10, 2021 20:10
@timj timj mentioned this pull request Dec 10, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants