DM-32883: Support StorageClass conversion on get. #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-32883
branch
from
8403ba6
to
c68f4b8
Compare
Codecov Report
@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 83.96% 84.05% +0.08%
==========================================
Files 234 234
Lines 30036 30166 +130
Branches 4976 4995 +19
==========================================
+ Hits 25221 25356 +135
+ Misses 3669 3666 -3
+ Partials 1146 1144 -2
Continue to review full report at Codecov.
|
timj
force-pushed
the
tickets/DM-32883
branch
3 times, most recently
from
937657f
to
91edc42
Compare
andy-slac
approved these changes
Dec 10, 2021
This allows a storage class to declare that it can convert some python types into the python type of that storage class.
If an incorrect python type is returned from the formatter it is possible to make a last ditch attempt to morph it to the required python type.
With storage class conversion now supported the code can no longer assume that the write storage class is going to match the read storage class. Change _coerceType to understand by storage classes and to allow python type coercion to the read storage class after coercion to the write storage class.
timj
force-pushed
the
tickets/DM-32883
branch
from
91edc42
to
8b07fa4
Compare
Properly test for bad converter exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a converter to be registered with a storage class that will be run if the dataset read from the datastore has an incorrect type that can be converted to the expected one.
Checklist
doc/changes