New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-33013: Add ipython display function to correctly print object #621
Conversation
9ab6818
to
46af1c5
Compare
Codecov Report
@@ Coverage Diff @@
## main #621 +/- ##
==========================================
+ Coverage 84.12% 84.14% +0.01%
==========================================
Files 237 237
Lines 30300 30305 +5
Branches 5008 5008
==========================================
+ Hits 25491 25499 +8
+ Misses 3664 3661 -3
Partials 1145 1145
Continue to review full report at Codecov.
|
7f1ab38
to
faa1b54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of special-purpose display methods but this does need a docstring and it also needs a test to make sure it doesn't crash when it runs.
The test can capture stdout or something (with _repr_html_
it's easier because that's a return value).
3eb3ccc
to
dbafd6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on the test code. Otherwise looks good to me.
dbafd6a
to
da29a6e
Compare
Checklist
doc/changes