Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33085: Specify explicit caching option for SQLAlchemy classes #624

Merged
merged 1 commit into from Jan 6, 2022

Conversation

andy-slac
Copy link
Contributor

Suppresses warnings about missing caching attribute for some classes.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #624 (4eaa635) into main (936d6f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   84.08%   84.09%           
=======================================
  Files         237      237           
  Lines       30014    30023    +9     
  Branches     4990     4989    -1     
=======================================
+ Hits        25238    25247    +9     
  Misses       3638     3638           
  Partials     1138     1138           
Impacted Files Coverage Δ
python/lsst/daf/butler/core/ddl.py 81.25% <100.00%> (+0.09%) ⬆️
...ython/lsst/daf/butler/registry/databases/sqlite.py 84.26% <100.00%> (ø)
...daf/butler/registry/queries/expressions/convert.py 80.87% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936d6f3...4eaa635. Read the comment docs.

@andy-slac andy-slac force-pushed the tickets/DM-33085 branch 2 times, most recently from 762ecf8 to 69eb07f Compare January 5, 2022 20:26
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I didn't dive into the SQLAlchemy docs to double-check your usage, though; if you were hoping I would do that, please just send it back to me.

Suppresses warnings about missing caching attribute for some classes.
@andy-slac andy-slac merged commit b8699d7 into main Jan 6, 2022
@andy-slac andy-slac deleted the tickets/DM-33085 branch January 6, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants