Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33174: Allow "@" in run collection names #627

Merged
merged 1 commit into from Jan 8, 2022
Merged

DM-33174: Allow "@" in run collection names #627

merged 1 commit into from Jan 8, 2022

Conversation

timj
Copy link
Member

@timj timj commented Jan 7, 2022

They were not included in the none-magic list of characters.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

They were not included in the none-magic list of characters.
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #627 (b629eb9) into main (b8699d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         237      237           
  Lines       30023    30027    +4     
  Branches     4989     4989           
=======================================
+ Hits        25247    25251    +4     
  Misses       3638     3638           
  Partials     1138     1138           
Impacted Files Coverage Δ
python/lsst/daf/butler/core/utils.py 88.88% <100.00%> (ø)
tests/test_butler.py 97.63% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8699d7...b629eb9. Read the comment docs.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@timj timj merged commit 853e70c into main Jan 8, 2022
@timj timj deleted the tickets/DM-33174 branch January 8, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants