Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-30966: Make Spectractions Gen3-serializable #633

Merged
merged 1 commit into from Jan 21, 2022
Merged

Conversation

mfisherlevine
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #633 (69ef0ca) into main (19f9d62) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   84.13%   84.13%           
=======================================
  Files         237      237           
  Lines       30216    30216           
  Branches     5022     5022           
=======================================
  Hits        25423    25423           
  Misses       3648     3648           
  Partials     1145     1145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f9d62...69ef0ca. Read the comment docs.

@mfisherlevine mfisherlevine marked this pull request as ready for review January 20, 2022 17:06
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd be happier if these used the FitsGenericFormatter, but I think that would involve pushing changes into the spectractor code, and I'm not clear on how difficult that is. The Spectrum and Image types would need to implement readFits and writeFits methods (likely as wrappers around the existing load_X and save_X methods).

@mfisherlevine mfisherlevine merged commit 1a2eac5 into main Jan 21, 2022
@mfisherlevine mfisherlevine deleted the tickets/DM-30966 branch January 21, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants