DM-33347: Fix compatibility with moto 3.0 #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moto3 broke the s3 tests solely in test_butler.py. It seems that something has changed in using the mock_s3 class decorator such that the inherited methods (the ones that are doing all the testing) are not actually using the mocks at all but are using raw boto. Moving the start and stop calls explicitly into setUp and tearDown fixes the problem.
Codecov Report
@@ Coverage Diff @@
## main #636 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 237 237
Lines 30214 30216 +2
Branches 5022 5022
=======================================
+ Hits 25421 25423 +2
Misses 3648 3648
Partials 1145 1145
Continue to review full report at Codecov.
|
ktlim
approved these changes
Jan 21, 2022
| @@ -1590,7 +1590,6 @@ def setUp(self): | |||
|
|
|||
|
|
|||
| @unittest.skipIf(not boto3, "Warning: boto3 AWS SDK not found!") | |||
| @mock_s3 | |||
There was a problem hiding this comment.
This looks like it follows the documentation, but it's a little unclear how inherited tests are handled.
Since this code works, I guess it's OK.
There was a problem hiding this comment.
Yes, the exact same mocking works fine in the resources package but that doesn't inherit tests from another class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moto3 broke the s3 tests solely in test_butler.py. It seems
that something has changed in using the mock_s3 class decorator
such that the inherited methods (the ones that are doing all
the testing) are not actually using the mocks at all but are
using raw boto. Moving the start and stop calls explicitly
into setUp and tearDown fixes the problem.
Checklist
doc/changes