Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33326: Fix round-tripping of spectractor spectra #644

Merged
merged 1 commit into from Feb 17, 2022

Conversation

mfisherlevine
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #644 (3cc6914) into main (5f8210b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files         239      239           
  Lines       30432    30432           
  Branches     5055     5055           
=======================================
  Hits        25498    25498           
  Misses       3789     3789           
  Partials     1145     1145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8210b...3cc6914. Read the comment docs.

Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this just be a Spectraction?

Don't forget to add the change message to the doc directory.

@mfisherlevine mfisherlevine changed the title DM-33326: Add pickle of spectractions DM-33326: Fix round-tripping of spectractor spectra Feb 17, 2022
@mfisherlevine mfisherlevine merged commit 5d83a09 into main Feb 17, 2022
@mfisherlevine mfisherlevine deleted the tickets/DM-33326 branch February 17, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants