Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-33772: Clean up the components warning in queryDatasetTypes #650

Merged
merged 3 commits into from Feb 24, 2022
Merged

DM-33772: Clean up the components warning in queryDatasetTypes #650

merged 3 commits into from Feb 24, 2022

Conversation

timj
Copy link
Member

@timj timj commented Feb 23, 2022 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj
Only ask for components if components might be needed
4a1aa50 
This prevents the possible warning if a storage class has
disappeared in the case where we don't care about components
anyhow.
@timj
Clean up warning message and factor it out
c6b69c0 
This is an error with finding the storage class definition
and not with loading the storage class.
@timj
Fix additional warnings from prune-collection tests
2eaf201
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #650 (2eaf201) into main (40211b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files         239      239           
  Lines       30245    30254    +9     
  Branches     5065     5066    +1     
=======================================
+ Hits        25286    25295    +9     
  Misses       3806     3806           
  Partials     1153     1153
Impacted Files Coverage Δ
python/lsst/daf/butler/registries/sql.py 81.74% <100.00%> (+0.07%) ⬆️
python/lsst/daf/butler/registry/tests/_registry.py 99.01% <100.00%> (+<0.01%) ⬆️
tests/test_cliCmdPruneCollection.py 97.82% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40211b7...2eaf201. Read the comment docs.

TallJimbo
TallJimbo approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, no other comments.

@timj timj merged commit 837304b into main Feb 24, 2022
@timj timj deleted the tickets/DM-33772 branch February 24, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo