Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33870: Support repo aliases in Butler constructor #654

Merged
merged 2 commits into from Mar 3, 2022
Merged

Conversation

timj
Copy link
Member

@timj timj commented Mar 2, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #654 (19addb8) into main (c999bd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files         239      239           
  Lines       30362    30377   +15     
  Branches     5087     5089    +2     
=======================================
+ Hits        25404    25419   +15     
  Misses       3805     3805           
  Partials     1153     1153           
Impacted Files Coverage Δ
python/lsst/daf/butler/_butler.py 81.02% <100.00%> (+0.26%) ⬆️
tests/test_butler.py 97.71% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c999bd6...19addb8. Read the comment docs.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor comments.

python/lsst/daf/butler/_butler.py Outdated Show resolved Hide resolved
tests/test_butler.py Outdated Show resolved Hide resolved
@timj timj merged commit fea7036 into main Mar 3, 2022
@timj timj deleted the tickets/DM-33870 branch March 3, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants