Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33890: Fix certifyCalibrations crash due to exception type change #655

Merged
merged 1 commit into from Mar 2, 2022

Conversation

andy-slac
Copy link
Contributor

Replaced exception catching with a collection type cheeck.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Replaced exception catching with a collection type cheeck.
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #655 (12d47b8) into main (b093713) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   83.66%   83.67%           
=======================================
  Files         239      239           
  Lines       30364    30362    -2     
  Branches     5086     5087    +1     
=======================================
  Hits        25404    25404           
+ Misses       3807     3805    -2     
  Partials     1153     1153           
Impacted Files Coverage Δ
...thon/lsst/daf/butler/script/certifyCalibrations.py 31.25% <0.00%> (+3.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b093713...12d47b8. Read the comment docs.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not spotting this tells us something about our test coverage of course.

@andy-slac
Copy link
Contributor Author

Not spotting this tells us something about our test coverage of course.

It's hard to write tests for 100% coverage with that level of complexity in the code. I'm worried there may be other cases like this, I did some grepping but it's hard to prove things that way.

@andy-slac andy-slac merged commit c999bd6 into main Mar 2, 2022
@andy-slac andy-slac deleted the tickets/DM-33890 branch March 2, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants