DM-33809: Change how --log-level works #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be changed later by the log-level call.
Codecov Report
@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 83.68% 83.69%
=======================================
Files 239 239
Lines 30401 30447 +46
Branches 5098 5106 +8
=======================================
+ Hits 25441 25482 +41
- Misses 3806 3811 +5
Partials 1154 1154
Continue to review full report at Codecov.
|
Encountered during log testing, if the subset is a simple string the command would not print it. Now fallback to using print() if the subset is not a Config.
Now only applies to the lsst logger or logger specified in the environment variable. This will stop non-LSST loggers from contaminating the output.
The lsst logger is always relevant to daf_butler so always set it. DAF_BUTLER_ROOT_LOGGER is now a colon-separated list of additional root loggers.
ktlim
approved these changes
Mar 9, 2022
| @@ -0,0 +1,4 @@ | |||
| The command-line tooling has changed how it sets the default logger when using ``--log-level``. | |||
| Now only the default logger(s) (``lsst`` and the colon-separated values stored in the ``$DAF_BUTLER_ROOT_LOGGER``) will be affected by using ``--log-level`` without a specific logger name. | |||
There was a problem hiding this comment.
See below for possible changes here and in line 4.
Co-authored-by: Kian-Tat Lim <ktl@slac.stanford.edu>
ktlim
reviewed
Mar 9, 2022
No other logger should have this name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now by default only applies to the lsst root logger.
Checklist
doc/changes