DM-34203: Ensure that lsstLog loggers are defaulted to WARNING #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this python root logger was WARNING but lsst.log root logger was DEBUG.
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
=======================================
Coverage 83.71% 83.71%
=======================================
Files 241 241
Lines 30626 30627 +1
Branches 5137 5137
=======================================
+ Hits 25639 25640 +1
Misses 3826 3826
Partials 1161 1161
Continue to review full report at Codecov.
|
ktlim
reviewed
Mar 28, 2022
| # Initialize the root logger. Calling this ensures that both | ||
| # python loggers and lsst loggers are consistent in their default | ||
| # logging level. | ||
| cls._setLogLevel(".", "WARNING") |
There was a problem hiding this comment.
I'm wondering a bit how this interacts with the basicConfig(level= above, but it looks OK.
ktlim
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this python root logger was WARNING but lsst.log root logger was DEBUG.
Checklist
doc/changes