Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34261: respond to click.Path api change #669

Merged
merged 5 commits into from Apr 1, 2022
Merged

Conversation

n8pease
Copy link
Contributor

@n8pease n8pease commented Mar 31, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@@ -0,0 +1 @@
The `click.Path` API changed, change from ordered arguments to keyword arguments when calling it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they may say that they always were expecting kwargs to be used. It's just they did not enforce that interface.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #669 (844dc37) into main (8243fde) will increase coverage by 0.02%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   83.73%   83.75%   +0.02%     
==========================================
  Files         241      241              
  Lines       30718    30722       +4     
  Branches     5155     5155              
==========================================
+ Hits        25721    25732      +11     
+ Misses       3832     3828       -4     
+ Partials     1165     1162       -3     
Impacted Files Coverage Δ
python/lsst/daf/butler/cli/opt/options.py 100.00% <ø> (ø)
python/lsst/daf/butler/tests/cliLogTestBase.py 90.44% <0.00%> (ø)
python/lsst/daf/butler/cli/butler.py 90.08% <100.00%> (ø)
...hon/lsst/daf/butler/cli/cmd/_remove_collections.py 100.00% <100.00%> (ø)
python/lsst/daf/butler/cli/cmd/_remove_runs.py 96.55% <100.00%> (ø)
python/lsst/daf/butler/cli/cmd/commands.py 91.27% <100.00%> (+0.97%) ⬆️
python/lsst/daf/butler/cli/progress.py 100.00% <100.00%> (ø)
python/lsst/daf/butler/cli/utils.py 93.51% <100.00%> (+0.68%) ⬆️
tests/test_cliCmdPruneDatasets.py 98.14% <100.00%> (+0.03%) ⬆️
tests/test_cliPluginLoader.py 96.10% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8243fde...844dc37. Read the comment docs.

@n8pease n8pease merged commit 94a159f into main Apr 1, 2022
@n8pease n8pease deleted the tickets/DM-34261 branch April 1, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants