Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33489: Implement unit tests for QuantumBackedButler #672

Merged
merged 1 commit into from Apr 7, 2022

Conversation

andy-slac
Copy link
Contributor

This also needed few changes to QBB classes to support serialization of
the provenance data.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #672 (6d64208) into main (8026ae2) will increase coverage by 0.49%.
The diff coverage is 96.30%.

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   83.76%   84.26%   +0.49%     
==========================================
  Files         241      242       +1     
  Lines       30729    30968     +239     
  Branches     5156     5216      +60     
==========================================
+ Hits        25739    26094     +355     
+ Misses       3828     3707     -121     
- Partials     1162     1167       +5     
Impacted Files Coverage Δ
...ython/lsst/daf/butler/registry/bridge/ephemeral.py 88.88% <66.66%> (ø)
...thon/lsst/daf/butler/registry/bridge/monolithic.py 84.53% <66.66%> (ø)
python/lsst/daf/butler/core/storedFileInfo.py 85.29% <87.50%> (-1.07%) ⬇️
python/lsst/daf/butler/_quantum_backed.py 89.88% <94.73%> (+89.88%) ⬆️
tests/test_quantumBackedButler.py 98.45% <98.45%> (ø)
python/lsst/daf/butler/__init__.py 100.00% <100.00%> (ø)
python/lsst/daf/butler/datastores/fileDatastore.py 80.63% <100.00%> (+0.56%) ⬆️
tests/test_quantum.py 97.40% <100.00%> (ø)
python/lsst/daf/butler/core/datastore.py 74.52% <0.00%> (+0.47%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8026ae2...6d64208. Read the comment docs.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor comments, though if we do have an import cycle I don't want to wait too long to get it fixed.

python/lsst/daf/butler/__init__.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/_quantum_backed.py Show resolved Hide resolved
python/lsst/daf/butler/_quantum_backed.py Outdated Show resolved Hide resolved
tests/test_quantumBackedButler.py Show resolved Hide resolved
@timj timj changed the title Implement unit tests for QuantumBackedButler (DM-33489) DM-33489: Implement unit tests for QuantumBackedButler Apr 6, 2022
This also needed few changes to QBB classes to support serialization of
the provenance data.
@andy-slac andy-slac merged commit da25978 into main Apr 7, 2022
@andy-slac andy-slac deleted the tickets/DM-33489 branch April 7, 2022 04:48
@timj timj mentioned this pull request Apr 7, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants