New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-34377: Add postgres testing for butler (including datastore) #676
Conversation
isort was confused by the try/except import blocks above.
This will ensure that datastore is tested with postgres.
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 84.26% 84.29% +0.03%
==========================================
Files 242 242
Lines 30971 31019 +48
Branches 5217 5219 +2
==========================================
+ Hits 26097 26149 +52
+ Misses 3707 3706 -1
+ Partials 1167 1164 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. General comment - the server setup logic repeats some of the test_postgresql.py
, would it be worth to move it to a common base class?
|
Is it 10% for |
The entire run of test_postgresql.py went from 60 seconds to 70 seconds when I used the postgre cache factory thing. |
This will hopefully catch the problem fixed by #675. We do not run postgres tests on Jenkins but we do run them in github actions. This test does fail if #675 is not applied.
Checklist
doc/changes