DM-33493: Add serialization support for datastore records #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 84.32% 84.29% -0.03%
==========================================
Files 242 243 +1
Lines 31055 31089 +34
Branches 5219 5235 +16
==========================================
+ Hits 26187 26208 +21
- Misses 3706 3714 +8
- Partials 1162 1167 +5
Continue to review full report at Codecov.
|
TallJimbo
approved these changes
Apr 14, 2022
TallJimbo
approved these changes
Apr 20, 2022
Adds a bunch of pydantic classes for datastore records and implements serialization of the records in `Quantum` class. I switched back `QuantumProvenanceData` to be a pydantic model to use the same pydantic classes for datastore records. Moved `DatastoreRecordData` class (and its pydantic friend) to a separate module, for some reason pydantic was not happy when I added `SerializedDatastoreRecordData` class to the `datastore` module.
Dropped `dataset_ids` member in favor of `records` keys. Dropped support for strings vs. UUIDs in a regular constructor, strings are only supported in direct() method. QuantumProvenanceData class had to add direct() method to enable construction from JSON data.
andy-slac
force-pushed
the
tickets/DM-33493
branch
from
70d1a35
to
9dcbcbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of pydantic classes for datastore records and implements
serialization of the records in
Quantumclass. I switched backQuantumProvenanceDatato be a pydantic model to use the same pydanticclasses for datastore records. Moved
DatastoreRecordDataclass (and itspydantic friend) to a separate module, for some reason pydantic was not
happy when I added
SerializedDatastoreRecordDataclass to thedatastoremodule.Checklist
doc/changes