DM-33946: Add healpix dimension #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the test to compare sets rather than dict keys improves the error reporting.
We cache universes by version number so this number must be changed for any environment where an old and new registry might be accessed by the same code.
The version number is not enough because other butlers can have different universes that will have the same version integer. Now allow a universe to define a namespace which is added to the cache key.
This was referenced May 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 84.30% 84.29% -0.02%
==========================================
Files 243 243
Lines 31057 31071 +14
Branches 5228 5232 +4
==========================================
+ Hits 26183 26190 +7
- Misses 3712 3715 +3
- Partials 1162 1166 +4
Continue to review full report at Codecov.
|
TallJimbo
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required we increment the dimensions.yaml version number. This also requires that we add a new namespace label to the dimensions.yaml so that it will not clash with other dimensions.yaml versions.
Checklist
doc/changes