Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33710: Add ScarletDataModel StorageClass #690

Merged
merged 1 commit into from Jun 8, 2022
Merged

Conversation

fred3m
Copy link
Contributor

@fred3m fred3m commented May 26, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #690 (07ff07e) into main (31b4056) will not change coverage.
The diff coverage is n/a.

❗ Current head 07ff07e differs from pull request most recent head c4bb603. Consider uploading reports for the commit c4bb603 to get more accurate results

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         243      243           
  Lines       31516    31516           
  Branches     5894     5894           
=======================================
  Hits        26605    26605           
  Misses       3741     3741           
  Partials     1170     1170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b4056...c4bb603. Read the comment docs.

@fred3m fred3m force-pushed the tickets/DM-33710 branch 2 times, most recently from 72e4e20 to d37fa34 Compare June 1, 2022 17:03
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message looks incorrect, but the change itself is fine.

@fred3m fred3m merged commit 6cfc7f8 into main Jun 8, 2022
@fred3m fred3m deleted the tickets/DM-33710 branch June 8, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants