DM-34919-v23: backport single commit: workaround change in column handling in astropy 5.1 #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v23.0.x #695 +/- ##
========================================
Coverage 83.78% 83.78%
========================================
Files 240 240
Lines 30510 30513 +3
Branches 5075 5075
========================================
+ Hits 25563 25566 +3
Misses 3760 3760
Partials 1187 1187
Continue to review full report at Codecov.
|
timj
approved these changes
Jun 14, 2022
yalsayyad
force-pushed
the
tickets/DM-34919-v23
branch
from
f49841f
to
3b5ecfb
Compare
complaint that _Yaml has no attribute encode
Astropy 5.1 has full support for multi-dimensional columns and so has changed the way that a timespan column is named. Support old and new approaches by checking astropy version.
yalsayyad
force-pushed
the
tickets/DM-34919-v23
branch
from
3b5ecfb
to
54d6225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Astropy 5.1 has full support for multi-dimensional columns
and so has changed the way that a timespan column is named.
Support old and new approaches by checking astropy version.
Checklist
doc/changes